-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Inconsistency with left/right icons in rtl/ltr when used within buttons and without buttons #10960
Comments
This is a documentation related issue as |
The margins are applied to the opposite side in rtl. And the documentation change does not fix this issue as the margins are applied even if it isn't inside a button. |
I just updated the codepen, and made it a bit sophisticated. As you can see for the buttons it looks great in both While in the examples without a button they look ugly and move closer to the text leaving a padding to the start of the line, and that's due the fact they are truly The direction-oriented behavior of icons in buttons is great, but it is super confusing for people writing i18n direction-agnostic websites for both Side note: I have always mentioned introducing |
Environment
Vuetify Version: 2.2.19
Vue Version: 2.6.11
Browsers: Waterfox 56.3
OS: Linux x86_64
Steps to reproduce
Use left/right in icon within buttons and without.
Expected Behavior
Consistency with left/right icons in rtl/ltr when used within buttons and without buttons
Actual Behavior
Inconsistency.
Reproduction Link
https://codepen.io/ibrahimbeladi/pen/ZEGVVVe?editors=1000
Other comments
Related to (but not duplicate of) #10619, #8461, and #9211.
I suggested before to add 'end' and 'start' props in addition to (or in place of) left/right;
See #10619 (comment) and #10619 (comment)
The text was updated successfully, but these errors were encountered: