Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] v-bottom-navigation's v-btn are't Vertical Centralization #8067

Closed
cheneyweb opened this issue Jul 26, 2019 · 11 comments
Closed
Assignees
Labels
C: VBottomNavigation CSS specificity Different CSS on dev and production good first issue A quick-win fix that would be great for new contributors has workaround T: bug Functionality that does not work as intended/expected
Milestone

Comments

@cheneyweb
Copy link

Environment

Vuetify Version: 2.0.1
Last working version: 1.5.16
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Mac OS 10.14.6

Steps to reproduce

use v-bottom-navigation follow the doc

Expected Behavior

the text and icon Vertical Centralization

image

Actual Behavior

the text and icon Centralized at the top

image

Reproduction Link

https://codepen.io/cheneyweb/pen/MNeEVe

@ghost ghost added the S: triage label Jul 26, 2019
@jacekkarczmarczyk
Copy link
Member

Can't reproduce in codepen
image

@jacekkarczmarczyk jacekkarczmarczyk added the S: needs reproduction The issue does not contain a valid reproduction label Jul 26, 2019
@cheneyweb
Copy link
Author

Can't reproduce in codepen
image

I don't know why it work find with codepen,but It do have problem with my localhost env.

even I ceate a new vue project with vue-cli and follow the doc to install plugin,I only write one v-bottom-navigation for test,and this problem still happen.

It really confuse me

@cheneyweb
Copy link
Author

@jacekkarczmarczyk

Finally, I find out how to fix this problem!

I have try a lot of times,and I find out if I append in the App.vue,the style of v-bottom-navigation will be correct !!!

I don't know why, but it work for me now.

and I still hope vuetify can fix this style problem as soon as possiable

image

@jacekkarczmarczyk
Copy link
Member

If the buttons show differently in dev and production mode please provide similar information like in another bottom nav issue (screenshots of devtool in both modes etc), otherwise we will have to close the issue as not being able to reproduce (and therefor provide a fix)

@cheneyweb
Copy link
Author

cheneyweb commented Jul 27, 2019

If the buttons show differently in dev and production mode please provide similar information like in another bottom nav issue (screenshots of devtool in both modes etc), otherwise we will have to close the issue as not being able to reproduce (and therefor provide a fix)

Here is the npm run serve result:

image

And Here is the npm run build result:
image
image

And If I kill the .v-btn:not(.v-btn--round).v-size--default height:36px style,everything is ok

image

image

So the reason of npm run serve different with npm run build is the order of CSS is different

The follow css code will fix this problem

`<style>
.v-bottom-navigation--fixed {position: fixed !important;}

.v-item-group.v-bottom-navigation .v-btn {height: inherit !important;}
</style>`

@jacekkarczmarczyk jacekkarczmarczyk added C: VBottomNavigation T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors and removed S: needs reproduction The issue does not contain a valid reproduction S: triage labels Jul 27, 2019
jareddantis added a commit to deckardsworkspace/gwa-calc that referenced this issue Jul 30, 2019
Also includes fix for incorrect v-btn size in v-bottom-navigation (see vuetifyjs/vuetify#8067)
@alamhubb
Copy link

<style>
    .v-item-group.v-bottom-navigation .v-btn.v-size--default {
        height: inherit;
    }
</style>

@Meowzz95

This comment has been minimized.

amitkummer added a commit to amitkummer/contrastor that referenced this issue Oct 9, 2020
This issue describes the reason for the problem and a workaround:
vuetifyjs/vuetify#8067
@johnleider
Copy link
Member

This is hard to reproduce simply because we have no control over CSS ordering and it's random. With this being said, this will not be an issue for the framework in version 3.

I'm going to close this as a duplicate of #5681 and #3583 as it pertains to them.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider self-assigned this Dec 10, 2020
@johnleider johnleider modified the milestone: v3.0.0 Dec 10, 2020
@kasperskov909
Copy link

kasperskov909 commented Feb 4, 2021

FYI I can reproduce in Vuetify 2.3.9.
Just if you happen to land here from Google.

The build config renders some button styling with explicit height above the regular height:inherit from .v-item-group.v-bottom-navigation button styling.

Just apply height: inherit; to your respective buttons in your bottom navigation component.

@neelansh15
Copy link

Adding on to this,

  • I had the issue where the bottom nav would sink in and disappear even without the hide-on-scroll prop. I just had the fixed and app props. It was surprisingly fixed by setting body overflow to hidden in the layout.
  • Also, in dark mode the background colour was lighter for the buttons and the padding was lesser in prod than in yarn dev.

Here is my complete bug fix in the style section of my default layout:

body{
  overflow: hidden;
}
.v-item-group.v-bottom-navigation .v-btn.v-size--default {
    height: inherit;
    background: #2e2e2e;
    padding: 0 1.3rem;
}

@johnleider
Copy link
Member

We kindly ask users to not comment on closed/resolved issues. If you believe that this issue has not been correctly resolved, please create a new issue showing the regression.

If you have any additional questions, please reach out to us in our Discord community.

@vuetifyjs vuetifyjs locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VBottomNavigation CSS specificity Different CSS on dev and production good first issue A quick-win fix that would be great for new contributors has workaround T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

7 participants