Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] VDialog doesn't get focus on first open #8220

Closed
avele opened this issue Jul 31, 2019 · 5 comments · Fixed by #8716
Closed

[Bug Report] VDialog doesn't get focus on first open #8220

avele opened this issue Jul 31, 2019 · 5 comments · Fixed by #8716
Assignees
@jacekkarczmarczyk
Labels
C: VDialog VDialog has workaround S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@avele
Copy link

avele commented Jul 31, 2019

Environment

Vuetify Version: 2.0.3
Vue Version: 2.6.10
Browsers: Chrome 76.0.3809.87
OS: Windows 10

Steps to reproduce

  1. Open reproduction link
  2. Click "Click me" button
  3. Press "esc" - nothing happens, dialog doesn't close
  4. Click outside of dialog - dialog closes
  5. Click "Click me" button again
  6. Now press "esc" - it works, dialog closes

Expected Behavior

Step 3 should close dialog

Actual Behavior

Dialog doesn't close

Reproduction Link

https://codepen.io/anon/pen/aeWxbp
@ghost ghost added the S: triage label Jul 31, 2019
@jacekkarczmarczyk jacekkarczmarczyk added C: VDialog VDialog T: bug Functionality that does not work as intended/expected has workaround and removed S: triage labels Jul 31, 2019
@jacekkarczmarczyk
Copy link
Member

Workaround https://codepen.io/anon/pen/BXZyba

@avele
Copy link
Author

avele commented Aug 2, 2019

Workaround https://codepen.io/anon/pen/BXZyba

Yeah adding eager prop works.

Looks like without it VDialog component tries to focus its content before it was rendered.

@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 24, 2019
jacekkarczmarczyk added a commit that referenced this issue Aug 24, 2019
@jacekkarczmarczyk
fix(VDialog): dialog is not focusing on first open
2b4b19e 
fixed #8220
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Aug 24, 2019
Merged
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Aug 24, 2019
johnleider pushed a commit that referenced this issue Aug 28, 2019
@jacekkarczmarczyk @johnleider
fix(VDialog): dialog is not focusing on first open
ee54da3 
fixed #8220
johnleider pushed a commit that referenced this issue Aug 28, 2019
@jacekkarczmarczyk @johnleider
fix(VDialog): dialog is not focusing on first open (#8716)
970ac5a 
fixes #8220
@avenmore
Copy link

avenmore commented Sep 4, 2019

Fix is all very well, but now autofocus on v-text-field is no longer working.

@jacekkarczmarczyk
Copy link
Member

@avenmore please create a new issue with reproduction if there's a bug

@avenmore
Copy link

avenmore commented Sep 4, 2019

@jacekkarczmarczyk Created issue #8845

johnleider pushed a commit that referenced this issue Sep 20, 2019
@jacekkarczmarczyk @johnleider
fix(VDialog): dialog is not focusing on first open (#8716)
9ed0bf1 
fixes #8220
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue May 2, 2020
Closed
nok-mh added a commit to nok-mh/ecamp3 that referenced this issue Nov 14, 2020
@nok-mh
Set eager prop on v-dialog so it closes on ESC on first show
e3cb154 
Workaround for issue vuetifyjs/vuetify#8220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekkarczmarczyk jacekkarczmarczyk

Labels
C: VDialog VDialog has workaround S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VDialog): dialog is not focusing on first open vuetifyjs/vuetify
3 participants
@avenmore @jacekkarczmarczyk @avele