Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] New treeview items set indeterminate state based on parent #8256

Closed
skycow opened this issue Aug 1, 2019 · 1 comment · Fixed by skyYaga/skdvin-webapp#22, skyYaga/skdvin-webapp#23 or anyulled/reactivewebflux#5
Closed

[Bug Report] New treeview items set indeterminate state based on parent #8256

skycow opened this issue Aug 1, 2019 · 1 comment · Fixed by skyYaga/skdvin-webapp#22, skyYaga/skdvin-webapp#23 or anyulled/reactivewebflux#5
Assignees
@nekosaur
Labels
C: VTreeview VTreeview S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Milestone
v2.2.x

Comments

@skycow
Copy link

skycow commented Aug 1, 2019

Environment

Vuetify Version: 2.0.3
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.100
OS: Windows 10

Steps to reproduce

  1. Expand the applications node
  2. Select an item in the list
  3. Click the Add Item button

Expected Behavior

The new item is added and is not selected or indeterminate.

Actual Behavior

The new item is added in an indeterminate state.

Reproduction Link

https://codepen.io/anon/pen/KOvVgj?&editable=true&editors=101

Other comments

New items' indeterminate state should be based on the children not the parent's indeterminate state.
@ghost ghost added the S: triage label Aug 1, 2019
@johnleider johnleider added the C: VTreeview VTreeview label Aug 1, 2019
@johnleider
Copy link
Member

This line:

vuetify/packages/vuetify/src/components/VTreeview/VTreeview.ts

Line 217 in 5a70900

node.isIndeterminate = this.nodes[parent].isIndeterminate

Not sure if this would ever be desired behavior. Thoughts @nekosaur ?

@johnleider johnleider added T: bug Functionality that does not work as intended/expected and removed S: triage labels Nov 21, 2019
skycow added a commit to skycow/vuetify that referenced this issue Dec 20, 2019
@skycow
fix(vtreeview): a node no longer sets indeterminate state based on pa…
0c0f970 
…rent, only by it's children

A Treeview node no longer sets it's indeterminate state based on it's parent. The indeterminate
state is only set by the default state, the node's previous state, or by the states of the node's
children.

fix vuetifyjs#8256
@skycow skycow mentioned this issue Dec 20, 2019
Closed
9 tasks
@johnleider johnleider added this to the v2.2.x milestone Jan 7, 2020
@johnleider johnleider added the S: has PR The issue has a pending Pull Request label Jan 7, 2020
@snyk-bot snyk-bot mentioned this issue Feb 27, 2020
Merged
This was referenced Mar 9, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nekosaur nekosaur

Labels
C: VTreeview VTreeview S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
v2.2.x
3 participants
@skycow @nekosaur @johnleider