Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] v-divider is not working as expected with inset attribute in RTL mode #8397

Closed
masoudyazdani opened this issue Aug 8, 2019 · 0 comments · Fixed by #8406
Closed

[Bug Report] v-divider is not working as expected with inset attribute in RTL mode #8397

masoudyazdani opened this issue Aug 8, 2019 · 0 comments · Fixed by #8406
Labels
C: VDivider good first issue A quick-win fix that would be great for new contributors rtl S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@masoudyazdani
Copy link

Environment

Vuetify Version: 2.0.5
Vue Version: 2.6.10
Browsers: Safari 12.1.2
OS: Mac OS 10.14.6

Steps to reproduce

1- Change Vuetify mode to RTL
2- See its effect on v-divider with inset attribute

Expected Behavior

Indent should be add from right when using RTL mode.

Actual Behavior

Indentation do not change when changing RTL mode.

Reproduction Link

https://codepen.io/msdyzdn/pen/xvjZyQ
@ghost ghost added the S: triage label Aug 8, 2019
@jacekkarczmarczyk jacekkarczmarczyk added C: VDivider rtl T: bug Functionality that does not work as intended/expected good first issue A quick-win fix that would be great for new contributors S: has PR The issue has a pending Pull Request and removed S: triage labels Aug 8, 2019
jacekkarczmarczyk added a commit that referenced this issue Aug 8, 2019
@jacekkarczmarczyk
fix(VDivider): missing rtl styles
95ff67b 
fixes #8397
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Aug 8, 2019
Merged
9 tasks
johnleider pushed a commit that referenced this issue Aug 12, 2019
@jacekkarczmarczyk @johnleider
fix(VDivider): missing rtl styles (#8406)
e629f12 
fixes #8397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: VDivider good first issue A quick-win fix that would be great for new contributors rtl S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(VDivider): missing rtl styles vuetifyjs/vuetify
2 participants
@jacekkarczmarczyk @masoudyazdani