Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): export interfaces #10161

Merged
merged 1 commit into from
Jan 12, 2020
Merged

fix(presets): export interfaces #10161

merged 1 commit into from
Jan 12, 2020

Conversation

betlgtu
Copy link
Contributor

@betlgtu betlgtu commented Jan 8, 2020

Motivation and Context

Configuration options should export.

How Has This Been Tested?

visually (Intelli Sense working)

import Vue from 'vue';
import Vuetify from 'vuetify/lib';
import { UserVuetifyPreset } from 'vuetify';

Vue.use(Vuetify);

const opts: Partial<UserVuetifyPreset> = {
  theme: {
    dark: false,
  },
};

export default new Vuetify(opts);

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@johnleider johnleider changed the title Presets interfaces need to be exported [Bug Fix] export preset interfaces Jan 10, 2020
@johnleider johnleider requested a review from KaelWD January 10, 2020 14:51
@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Jan 10, 2020
@johnleider johnleider added this to the v2.2.x milestone Jan 10, 2020
@johnleider johnleider changed the title [Bug Fix] export preset interfaces fix(presets): export interfaces Jan 10, 2020
@johnleider johnleider merged commit 843a875 into vuetifyjs:master Jan 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants