Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSlideGroup): add display none to immediate child #10567

Merged

Conversation

tanmoyopenroot
Copy link
Contributor

fix #10310

Description

Motivation and Context

Instead of adding display: none to any child it should add to its immediate child

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-container>
      <v-card width="800">
        <v-slide-group :show-arrows="true">
          <v-slide-item
            v-for="n in 2"
            :key="n"
          >
            <v-card
              color="accent"
              class="ma-1"
              width="200"
            >
              <v-slide-group :show-arrows="true">
                <v-slide-item
                  v-for="item in items"
                  :key="item"
                >
                  {{ item }}
                </v-slide-item>
              </v-slide-group>
            </v-card>
          </v-slide-item>
        </v-slide-group>
      </v-card>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      //
      items: [
        'hello',
        'there',
        'cat',
        'dog',
        'train',
        'mixer',
        'friend',
        'bobcat',
        'marker',
      ],
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk changed the title fix(vslidegroup): add display none to immediate child fix(VSlideGroup): add display none to immediate child Feb 18, 2020
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.2.x milestone Feb 18, 2020
@MajesticPotatoe MajesticPotatoe added C: VSlideGroup T: bug Functionality that does not work as intended/expected labels Feb 18, 2020
@MajesticPotatoe MajesticPotatoe merged commit bb69192 into vuetifyjs:master Feb 18, 2020
Logikgate pushed a commit to flypapertech/vuetify that referenced this pull request Feb 19, 2020
fix vuetifyjs#10310

Co-authored-by: Jacek Karczmarczyk <jkarczm@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
whoistobias pushed a commit to whoistobias/vuetify that referenced this pull request Feb 26, 2020
fix vuetifyjs#10310

Co-authored-by: Jacek Karczmarczyk <jkarczm@gmail.com>
Co-authored-by: Andrew Henry <AMajesticPotatoe@gmail.com>
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VSlideGroup T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Nested v-slide-group's inner next arrow visibility depends on the outer group.
3 participants