Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTextField): show label slot when filled prop is used #12371

Merged
merged 2 commits into from
Oct 8, 2020

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Oct 7, 2020

fixes #11533
see vuejs/vue#11714

Does this break anything? Is there some way setLabelWidth would need to be called before the watcher is set up?

Markup:

<template>
  <v-container>
    <v-text-field filled>
      <template #label><span>#Slot label</span></template>
    </v-text-field>

    <v-text-field filled>
      <template slot="label"><span>Slot label</span></template>
    </v-text-field>

    <v-text-field filled label="Prop label" />
  </v-container>
</template>

@johnleider johnleider added this to the v2.3.x milestone Oct 7, 2020
@johnleider johnleider added C: VTextField T: bug Functionality that does not work as intended/expected labels Oct 7, 2020
@@ -196,7 +196,7 @@ export default baseMixins.extend<options>().extend({
},

watch: {
labelValue: 'setLabelWidth',
// labelValue: 'setLabelWidth', // moved to mounted, see #11533
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intent to leave this or just remaining dev code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended, can remove though if you like

@johnleider
Copy link
Member

I don't see anything that this would obviously break.

@KaelWD KaelWD merged commit 0244fb3 into master Oct 8, 2020
@KaelWD KaelWD deleted the fix/11533-filled-label-slot branch October 8, 2020 11:07
francois2metz pushed a commit to francois2metz/vuetify that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-text-field + filled (v-slot:label not working)
2 participants