-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VTextField): show label slot when filled prop is used #12371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnleider
reviewed
Oct 7, 2020
@@ -196,7 +196,7 @@ export default baseMixins.extend<options>().extend({ | |||
}, | |||
|
|||
watch: { | |||
labelValue: 'setLabelWidth', | |||
// labelValue: 'setLabelWidth', // moved to mounted, see #11533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intent to leave this or just remaining dev code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended, can remove though if you like
I don't see anything that this would obviously break. |
KaelWD
added a commit
that referenced
this pull request
Oct 8, 2020
jyburns
pushed a commit
to jyburns/vuetify
that referenced
this pull request
Oct 11, 2020
jyburns
pushed a commit
to jyburns/vuetify
that referenced
this pull request
Oct 11, 2020
francois2metz
pushed a commit
to francois2metz/vuetify
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11533
see vuejs/vue#11714
Does this break anything? Is there some way
setLabelWidth
would need to be called before the watcher is set up?Markup: