-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VChip): add aria-label to chip close button #12384
fix(VChip): add aria-label to chip close button #12384
Conversation
Looking for guidance on properly updating the API docs. Initially thought https://github.com/vuetifyjs/vuetify/blob/master/packages/api-generator/src/locale/en/v-chip.json would be the file to update, but it is gitignored. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- That file is correct, change the gitignore to
!/src/locale/en
- Don't need a new test, it's already covered by the snapshot
- v-alert calls the prop
closeLabel
- This adds a new prop so rebase to dev:
git fetch && git rebase origin/dev && git push --force
then click edit on github and change the base branch
290f24a
to
a7643f3
Compare
b7f41c8
to
fec29c6
Compare
fec29c6
to
4dd9cc4
Compare
@KaelWD Thanks for your feedback! I was being associated with previous commits to the dev branch after rebasing... I was able to get the diff to just reflect my changes again but i'm afraid I lost my previous commit history in the process. Apologies for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.
Description
fixes #11165 by adding a default aria-label of
'$vuetify.close'
to the close<button>
tag on VChip. This change also created a new prop ofclose-label
on VChip.Motivation and Context
#11165
How Has This Been Tested?
Tested in playground and with unit tests. Added a unit test to check for new aria-label when expected.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).