-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VFab): add new component #18083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ce7b02
to
1adfeaa
Compare
bb07313
to
e5c1c07
Compare
2a69771
to
9fd00df
Compare
7cd11a6
to
d0765f1
Compare
f931c2e
to
748056c
Compare
02f799e
to
ec2ce7f
Compare
cd170f8
to
98e57dc
Compare
ec2ce7f
to
c517ae5
Compare
c517ae5
to
40de64f
Compare
40de64f
to
3f00ab5
Compare
b1c7135
to
e8d0862
Compare
e8d0862
to
b01a98e
Compare
46a3cd5
to
45912f8
Compare
this causes a multitude of backwards compat issues and I can't see a reason for it. V2 keeps it on content only as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #1852
fixes #2553
fixes #7407
Markup: