Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor/doc slots #6502

Merged
merged 51 commits into from
Feb 28, 2019
Merged

docs: refactor/doc slots #6502

merged 51 commits into from
Feb 28, 2019

Conversation

MajesticPotatoe
Copy link
Member

@MajesticPotatoe MajesticPotatoe commented Feb 15, 2019

Description

Update docs and doc examples to use new slot syntax

Motivation and Context

Because slot life is best life
Closes #6440

How Has This Been Tested?

Visually, Lint

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

packages/docs/src/examples/combobox/advanced.vue Outdated Show resolved Hide resolved
packages/docs/src/examples/combobox/comboboxMultiple.vue Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #6502 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6502      +/-   ##
==========================================
+ Coverage   85.59%   85.59%   +<.01%     
==========================================
  Files         298      298              
  Lines        7162     7163       +1     
  Branches     1781     1782       +1     
==========================================
+ Hits         6130     6131       +1     
  Misses        942      942              
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/components/VIcon/VIcon.ts 100% <0%> (ø) ⬆️
...ages/vuetify/src/components/VCarousel/VCarousel.ts 91.66% <0%> (ø) ⬆️
packages/vuetify/src/mixins/menuable.js 88.8% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a546c75...46349d4. Read the comment docs.

@vercel vercel bot temporarily deployed to staging February 16, 2019 03:22 Inactive
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #6502 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6502      +/-   ##
==========================================
- Coverage   85.68%   85.68%   -0.01%     
==========================================
  Files         298      298              
  Lines        7175     7174       -1     
  Branches     1785     1785              
==========================================
- Hits         6148     6147       -1     
  Misses        936      936              
  Partials       91       91
Impacted Files Coverage Δ
packages/vuetify/src/directives/ripple.ts 75.59% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bf395c...45b8fd5. Read the comment docs.

@MajesticPotatoe MajesticPotatoe merged commit 67b73b9 into master Feb 28, 2019
@MajesticPotatoe MajesticPotatoe deleted the refactor/doc-slots branch February 28, 2019 22:52
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-tooltip does not work when activator is set using the new slot syntax
7 participants