Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): update TypeScript to 3.6.3 #8933

Closed
wants to merge 2 commits into from
Closed

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Sep 11, 2019

Description

Update TypeScript to v3.6.3, update related dependencies and fix issues caused/found by update.

Motivation and Context

TypeScript has been updated to v3.6.3 which provides a better functionality.

How Has This Been Tested?

jest + yarn build + yarn lint

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@dsseng dsseng added T: enhancement Functionality that enhances existing features typescript labels Sep 11, 2019
@dsseng dsseng requested a review from KaelWD September 11, 2019 18:09
@TravisBuddy
Copy link

TravisBuddy commented Sep 11, 2019

Travis tests have failed

Hey @sh7dm,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 12

View build log

yarn run lint
yarn run v1.15.2
$ lerna run lint --parallel
lerna notice cli v3.16.2
lerna info ci enabled
lerna info Executing command in 4 packages: "yarn run lint"
@vuetify/api-generator: $ eslint --ext .js src
@vuetify/kitchen: $ eslint --ext .js,.vue src
vuetifyjs.com: $ eslint --ext .js,.vue,.json src -f codeframe
vuetify: $ concurrently -n "tsc,tslint,eslint,types" --kill-others-on-fail "tsc --noEmit --pretty" "tslint -p . src/**/*.ts -t verbose" "eslint --ext .js,.ts src" "yarn test:types"
vuetify: [types] $ tsc -p ./types/test/tsconfig.json
vuetify: [tslint] no-use-before-declare is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.
vuetify: [tslint] tslint -p . src/**/*.ts -t verbose exited with code 0
vuetify: [types] yarn test:types exited with code 0
vuetify: [tsc] src/components/VAutocomplete/VAutocomplete.ts:85:48 - error TS2349: This expression is not callable.
vuetify: [tsc]   No constituent of type 'boolean | Function' is callable.
vuetify: [tsc] 
vuetify: [tsc] 85       return this.allItems.filter(item => this.filter(item, String(this.internalSearch), String(this.getText(item))))
vuetify: [tsc]                                                   ~~~~~~
vuetify: [tsc] 
vuetify: [tsc] src/components/VData/VData.ts:155:22 - error TS2349: This expression is not callable.
vuetify: [tsc]   Not all constituents of type 'any[] | ((items: any[], search: string) => any[])' are callable.
vuetify: [tsc]     Type 'any[]' has no call signatures.
vuetify: [tsc] 
vuetify: [tsc] 155         items = this.customFilter(items, this.search)
vuetify: [tsc]                          ~~~~~~~~~~~~
vuetify: [tsc] 
vuetify: [tsc] src/components/VData/VData.ts:353:19 - error TS2349: This expression is not callable.
vuetify: [tsc]   Not all constituents of type 'any[] | ((items: any[], sortBy: string[], sortDesc: boolean[], locale: string, customSorters?: Record<string, compareFn<any>> | undefined) => any[])' are callable.
vuetify: [tsc]     Type 'any[]' has no call signatures.
vuetify: [tsc] 
vuetify: [tsc] 353       return this.customSort(items, sortBy, sortDesc, this.locale)
vuetify: [tsc]                       ~~~~~~~~~~
vuetify: [tsc] 
vuetify: [tsc] src/components/VDataTable/VDataTable.ts:200:19 - error TS2349: This expression is not callable.
vuetify: [tsc]   Not all constituents of type 'any[] | ((items: any[], sortBy: string[], sortDesc: boolean[], locale: string, customSorters?: Record<string, compareFn<any>> | undefined) => any[])' are callable.
vuetify: [tsc]     Type 'any[]' has no call signatures.
vuetify: [tsc] 
vuetify: [tsc] 200       return this.customSort(items, sortBy, sortDesc, locale, this.columnSorters)
vuetify: [tsc]                       ~~~~~~~~~~
vuetify: [tsc] 
vuetify: [tsc] src/components/VTimePicker/VTimePickerClock.ts:139:48 - error TS2349: This expression is not callable.
vuetify: [tsc]   No constituent of type 'string | number | Function' is callable.
vuetify: [tsc] 
vuetify: [tsc] 139           domProps: { innerHTML: `<span>${this.format(value)}</span>` },
vuetify: [tsc]                                                    ~~~~~~
vuetify: [tsc] 
vuetify: [tsc] 
vuetify: [tsc] Found 5 errors.
vuetify: [tsc] 
vuetify: [tsc] tsc --noEmit --pretty exited with code 1
vuetify: --> Sending SIGTERM to other processes..
vuetify: [eslint] eslint --ext .js,.ts src exited with code SIGTERM
vuetify: error Command failed with exit code 1.
vuetify: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run lint exited 1 in 'vuetify'
lerna ERR! yarn run lint stdout:
$ concurrently -n "tsc,tslint,eslint,types" --kill-others-on-fail "tsc --noEmit --pretty" "tslint -p . src/**/*.ts -t verbose" "eslint --ext .js,.ts src" "yarn test:types"
[types] $ tsc -p ./types/test/tsconfig.json
[tslint] no-use-before-declare is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.
[tslint] tslint -p . src/**/*.ts -t verbose exited with code 0
[types] yarn test:types exited with code 0
[tsc] src/components/VAutocomplete/VAutocomplete.ts:85:48 - error TS2349: This expression is not callable.
[tsc]   No constituent of type 'boolean | Function' is callable.
[tsc] 
[tsc] 85       return this.allItems.filter(item => this.filter(item, String(this.internalSearch), String(this.getText(item))))
[tsc]                                                   ~~~~~~
[tsc] 
[tsc] src/components/VData/VData.ts:155:22 - error TS2349: This expression is not callable.
[tsc]   Not all constituents of type 'any[] | ((items: any[], search: string) => any[])' are callable.
[tsc]     Type 'any[]' has no call signatures.
[tsc] 
[tsc] 155         items = this.customFilter(items, this.search)
[tsc]                          ~~~~~~~~~~~~
[tsc] 
[tsc] src/components/VData/VData.ts:353:19 - error TS2349: This expression is not callable.
[tsc]   Not all constituents of type 'any[] | ((items: any[], sortBy: string[], sortDesc: boolean[], locale: string, customSorters?: Record<string, compareFn<any>> | undefined) => any[])' are callable.
[tsc]     Type 'any[]' has no call signatures.
[tsc] 
[tsc] 353       return this.customSort(items, sortBy, sortDesc, this.locale)
[tsc]                       ~~~~~~~~~~
[tsc] 
[tsc] src/components/VDataTable/VDataTable.ts:200:19 - error TS2349: This expression is not callable.
[tsc]   Not all constituents of type 'any[] | ((items: any[], sortBy: string[], sortDesc: boolean[], locale: string, customSorters?: Record<string, compareFn<any>> | undefined) => any[])' are callable.
[tsc]     Type 'any[]' has no call signatures.
[tsc] 
[tsc] 200       return this.customSort(items, sortBy, sortDesc, locale, this.columnSorters)
[tsc]                       ~~~~~~~~~~
[tsc] 
[tsc] src/components/VTimePicker/VTimePickerClock.ts:139:48 - error TS2349: This expression is not callable.
[tsc]   No constituent of type 'string | number | Function' is callable.
[tsc] 
[tsc] 139           domProps: { innerHTML: `<span>${this.format(value)}</span>` },
[tsc]                                                    ~~~~~~
[tsc] 
[tsc] 
[tsc] Found 5 errors.
[tsc] 
[tsc] tsc --noEmit --pretty exited with code 1
--> Sending SIGTERM to other processes..
[eslint] eslint --ext .js,.ts src exited with code SIGTERM
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

lerna ERR! yarn run lint stderr:
error Command failed with exit code 1.

lerna ERR! yarn run lint exited 1 in 'vuetify'
lerna WARN complete Waiting for 1 child process to exit. CTRL-C to exit immediately.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
TravisBuddy Request Identifier: 886a2d60-d7d0-11e9-b57f-f7c3bbd28520

@dsseng
Copy link
Contributor Author

dsseng commented Sep 15, 2019

This one is blocked by vuejs/vue#9357

@dsseng dsseng added the S: on hold The issue is on hold until further notice label Sep 15, 2019
@jacekkarczmarczyk
Copy link
Member

I guess we can close this in favour of #9594

@KaelWD KaelWD deleted the chore/ts-363 branch November 12, 2019 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: on hold The issue is on hold until further notice S: work in progress T: enhancement Functionality that enhances existing features typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants