Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useEventSource): return lastEventId #3984

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

pkc918
Copy link
Contributor

@pkc918 pkc918 commented May 20, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fixes: #3974

Additional context

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 20, 2024
@antfu antfu merged commit 29bc690 into vueuse:main May 27, 2024
4 checks passed
@pkc918 pkc918 deleted the useEventSource branch May 30, 2024 15:55
@max06
Copy link

max06 commented Jun 4, 2024

Thank you very much for your quick solution, I really appreciate it! 🙇🏼

The question I added to the original issue probably got overseen - I hope you don't mind:

More a question... since watch requires ticks between changes to not miss-out on updates, does useEventSource make sure to pass all messages along? Is there any chance we could miss messages if, let's say our source burst sends 100 updates at once?

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useEventSource: Return id besides event and data
3 participants