Discussion changes

vufind-org · Dec 2, 2024 · ec04495 · ec04495
1 parent aaf958e
commit ec04495
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/themes/bootstrap3/js/facets.js b/themes/bootstrap3/js/facets.js
@@ -140,7 +140,7 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
   const activation_event = 'facet-selection-begin';
   const deactivation_event = 'facet-selection-cancel';
   const apply_event = 'facet-selection-done';
-  const localStorageVariableName = 'multiFacetsSelection';
+  const local_storage_variable_name = 'multiFacetsSelection';
 
   /**
    * Normalize a filter value
@@ -299,12 +299,17 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
   }
 
   function saveUserSelectionLastState(state) {
-    localStorage.setItem(localStorageVariableName, state);
+    localStorage.setItem(local_storage_variable_name, state);
+  }
+
+  function getUserSelectionLastState() {
+    return localStorage.getItem(local_storage_variable_name) === 'true';
   }
 
   function toggleMultiFacetsSelection(enable) {
     if (typeof enable !== 'undefined') {
       isMultiFacetsSelectionActivated = enable;
+      saveUserSelectionLastState(isMultiFacetsSelectionActivated);
     }
     document.querySelectorAll('.multi-facet-selection').forEach( el => el.classList.toggle('multi-facet-selection-active', isMultiFacetsSelectionActivated) );
     const checkboxes = document.getElementsByClassName('js-user-selection-multi-filters');
@@ -318,7 +323,6 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
         toggleSelectedFacetStyle(elem);
       }
     }
-    saveUserSelectionLastState(isMultiFacetsSelectionActivated);
     const event = isMultiFacetsSelectionActivated ? activation_event : deactivation_event;
     VuFind.emit(event);
   }
@@ -344,7 +348,7 @@ VuFind.register('multiFacetsSelection', function multiFacetsSelection() {
     const activationElem = context.querySelector('.js-user-selection-multi-filters');
     if (activationElem) {
       activationElem.addEventListener('change', function multiFacetSelectionChange() { toggleMultiFacetsSelection(this.checked); } );
-      toggleMultiFacetsSelection(localStorage.getItem(localStorageVariableName) === 'true');
+      toggleMultiFacetsSelection(getUserSelectionLastState());
     }
     // Listener on apply filters button
     const applyElem = context.querySelector('.js-apply-multi-facets-selection');