Fix email-based catalog login from record holdings tab. #3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
approved these changes
Aug 14, 2023
EreMaijala
added a commit
to EreMaijala/vufind
that referenced
this pull request
Aug 16, 2023
EreMaijala
pushed a commit
to EreMaijala/vufind
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without route parameters the route doesn't include the record id or current tab. Without the catalogLogin parameter record controller wouldn't process the login request. The issue arises when a user has already logged in to VuFind but doesn't have a library card attached. If they try to add it using the link on the record holdings tab, it would result in a broken link to be sent via email.
This changes the signature of EmailAuthenticator::sendAuthenticationLink, but I believe it's worth it.