Move record version key handling to the new Versions helper. #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the functionality reusable and overridable.
9 tasks
|
Mink tests are passing for me. |
demiankatz
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Thanks, @EreMaijala. A couple of small comments. Also, is it worth adding a unit test for the new class? If this is already fully covered by integration tests, perhaps that's not a high priority, though generally I like to add tests for new code when practical.
module/VuFind/src/VuFind/Controller/Feature/RecordVersionsSearchTrait.php
Outdated
Show resolved
Hide resolved
demiankatz
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Looks good to me. Thanks, @EreMaijala!
(I know I said I was out of time, but then I couldn't stop...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the functionality reusable and overridable.
Extracted from #2929.