Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibility: top recommendations to ul. #3107

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

crhallberg
Copy link
Contributor

Separated from #3039.

@sturkel89
Copy link
Contributor

I've tested this branch and compared it with dev.

As far as I can tell, the experience on the front end is identical. Everything looks the same between test and dev in all three themes, using a combination of facet options (exclude, or, and neither).

Good work, and ready to merge, as far as I can tell!

@demiankatz demiankatz added this to the 9.1 milestone Sep 28, 2023
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and full test suite is passing.

@demiankatz demiankatz merged commit 3b57baa into vufind-org:dev Sep 28, 2023
EreMaijala added a commit to EreMaijala/vufind that referenced this pull request Dec 19, 2024
…information gracefully. (vufind-org#3107)

The button style fix improves forward-compatibility with Bootstrap 5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants