Sierra: Fix and improve item/bib handling with transaction history #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EreMaijala
commented
Oct 2, 2023
EreMaijala
commented
- Allows a bib to be fetched also when the item has already been deleted
- Fixes an issue when the transaction list contained multiple items for the same bib where only one item had it's bib mapped to it.
- Allows a bib to be fetched also when the item has already been deleted - Fixes an issue when the transaction list contained multiple items for the same bib where only one item had it's bib mapped to it.
demiankatz
requested changes
Oct 2, 2023
| * | ||
| * @return string | ||
| */ | ||
| protected function extractCallNumber(string $callNumber): string |
There was a problem hiding this comment.
This seems to be reverting changes from another recent Sierra PR. Is that intentional? It doesn't seem related to the intent of this one...
There was a problem hiding this comment.
Oops, I thought I took care of that. That's what you get for working with so many different versions. Should be fixed now.
demiankatz
approved these changes
Oct 2, 2023
EreMaijala
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Oct 3, 2023
…ufind-org#3133) - Allows a bib to be fetched also when the item has already been deleted - Fixes an issue when the transaction list contained multiple items for the same bib where only one item had its bib mapped to it.
LuomaJuha
pushed a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Oct 3, 2023
…ufind-org#3133) - Allows a bib to be fetched also when the item has already been deleted - Fixes an issue when the transaction list contained multiple items for the same bib where only one item had its bib mapped to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.