Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolder text in filter dropdown. #3138

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

demiankatz
Copy link
Member

@sturkel pointed out that the drop-down control for combined filters used regular-weight font while all the surrounding buttons and filters have heavier font weights. This PR adjusts the combined filter to match for a more consistent visual experience.

@demiankatz demiankatz added this to the 9.1 milestone Oct 3, 2023
@sturkel89
Copy link
Contributor

DEV BRANCH:

Bootstrap3 - Combined filters button is normal, rest of filter buttons are bold

image

Bootprint3 -Button text text is bold on all filter buttons (no change needed)

image

Sandal - Combined filters button is normal, rest of filter buttons are bold

image

TEST BRANCH:

Bootstrap3 - All filter buttons have same bold font.

image

Bootprint3 - All filter buttons have same bold font.

image

Sandal - All filter buttons have same bold font.

image

CONCLUSION

In each of the three themes, all filter buttons now have the same bold font. So, the problem this PR seeks to address has been solved.

FOR A FUTURE PR
We still may want to consider revamping the look of the combined filter button. In all cases, the combined filter button is taller than the other filter buttons, with extra padding in all dimensions. Also, it has rounded corners, while the rest of the filter buttons have less padding and sharp corners. I think the heights should be brought into alignment so that vertical line spacing is normalized; not sure whether rounded corners should be changed or not.

One theme-specific nitpick: in Bootprint3, there seems to be more top padding than bottom padding in the regular filter buttons. The text should probably be vertically centered within the button, and the button might look better if it were a bit taller overall.

Thanks, @demiankatz!

@demiankatz demiankatz merged commit 3622371 into vufind-org:dev Oct 4, 2023
6 checks passed
@demiankatz demiankatz deleted the bolder-filter-dropdown branch October 4, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants