Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filters and custom heading on recommendation modules #3192

Merged
merged 17 commits into from
Nov 14, 2023
Merged

Support filters and custom heading on recommendation modules #3192

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fe486fe
Support hiddenFilters on recommendation modules
maccabeelevine Nov 3, 2023
e8fcda8
Simplify ini section for hidden filters
maccabeelevine Nov 6, 2023
971f09b
Replace InjectSearchRunnerFactory with AbstractSearchObjectFactory
maccabeelevine Nov 6, 2023
d9ba2b5
Fix tests
maccabeelevine Nov 6, 2023
ac8edfe
Add missing doc param
maccabeelevine Nov 6, 2023
cf8b4ed
Improve doc.
maccabeelevine Nov 6, 2023
c94ba8e
Remove $iniSection variable
maccabeelevine Nov 6, 2023
19b6e2c
Document other modules (even if wrong)
maccabeelevine Nov 6, 2023
2d12789
Fix phpcbf
maccabeelevine Nov 6, 2023
8c5ae0c
Flip config of $iniSection and $customHeading
maccabeelevine Nov 7, 2023
700fc46
Set default headings within code, and drop filter from modules that d…
maccabeelevine Nov 7, 2023
c7f7d2f
Remove word 'hidden'
maccabeelevine Nov 7, 2023
a778f1e
Document new param on Deferred modules
maccabeelevine Nov 7, 2023
b5f2e74
Merge branch 'dev' into recommendation-filter
maccabeelevine Nov 13, 2023
88e676e
Rename $iniSection for clarity
maccabeelevine Nov 13, 2023
a20dcc4
Merge branch 'dev' into recommendation-filter
maccabeelevine Nov 14, 2023
4b80e52
Rewrap line for consistency.
demiankatz Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/vufind/searches.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ WorkKeys = year
; GET parameter (default = "lookfor"), limited to a specified number of
; matches (default = 5). This is designed for use with non-catalog modules.
; Hidden filters may be defined in the specified section of the searches.ini
; file. The optional custom heading overrides the default for this
; recommendation module.
; file; see [CatalogResultsVideoFilter] below for an example ofthis. The
demiankatz marked this conversation as resolved.
Show resolved Hide resolved
; optional custom heading overrides the default for this recommendation module.
; DPLATerms:[collapsed]
; Display results from the DPLA catalog. Provide a boolean to have the sidebar
; collapsed or open on page load.
Expand Down