Replace substr with e.g. str_starts_with or str_ends_with where appropriate. #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks, @EreMaijala, this makes a lot of code significantly more readable, in addition to improving efficiency. I just had a couple of questions and observations from my review....
| @@ -1496,7 +1496,7 @@ protected function extractComments($filename) | |||
| // Is the current line a setting? If so, add to the return value: | |||
| $set = trim(substr($trimmed, 0, $equals)); | |||
| $set = trim(str_replace('[]', '', $set)); | |||
| if (!empty($section) && !empty($set)) { | |||
| if ('' == $section && '' == $set) { | |||
There was a problem hiding this comment.
This seems to be reversing the logic. If this didn't cause a test to fail, maybe we'd better add another test.
There was a problem hiding this comment.
Oops, fixed! It'd only affect inline comments, but yes, not caught by any test.
There was a problem hiding this comment.
I've just pushed up a test to cover this code, and confirmed that it failed before your fix and passes after.
demiankatz
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling VuFind I noticed that there was a relatively high number of
substrcalls. While many of them are necessary, there was a lot of old code using them for comparison, so here's a bit cleanup. All tests are passing for me, but this was all manual work, so some scrutiny is welcome.TODO