Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for bulk deleting from favorite list. #3202

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

demiankatz
Copy link
Member

It was revealed during testing of demiankatz#26 that we lacked an integration test for bulk deleting from a favorites list. This PR adds the missing test and also improves typing within the BulkTest.

@demiankatz demiankatz added this to the 10.0 milestone Nov 8, 2023
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and tests are passing.

@demiankatz
Copy link
Member Author

Thanks, @EreMaijala!

@demiankatz demiankatz merged commit 25e62f5 into vufind-org:dev Nov 9, 2023
6 checks passed
@demiankatz demiankatz deleted the bulk-list-delete-test branch November 9, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants