Combined: Fix scope of search cart form #3219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In search/results.phtml the form element
<form id="search-cart-form" ...
wraps just a single line, the call to render search/bulk-action.buttons.phtml.
In combined/results.phtml, the same form wraps most of the whole file. It looks like search/results.phtml used to do the same, but was refactored in #802.
This is a problem just now because after #3135 one of the things it wraps is side recommendations, which can include SideFacets.phtml, which can include range-slider.phtml, which defines its own form. It's invalid HTML to have a form nested within another form, and forces the browser to move the entire sidebar div outside of the search-cart-form. This in turn messes up the styling assumptions where div.mainbody and div.sidebar are both floated and assumed to be adjacent elements.
This PR changes combined/results.phtml so the form scope mirrors search/results.phtml.