Virtual keyboard: Avoid !important with more specific selectors, escape attrs properly. #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
changed the title
|
@sturkel89, do you mind double-checking that the virtual keyboards (activated in searchbox.ini) still look correct in all themes after applying these changes? |
sturkel89
approved these changes
Nov 15, 2023
|
Thanks, @sturkel89 -- this looks fine to me as well, but I'll wait to hear from @ThoWagen before merging in case he has any concerns, being the person most familiar with this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style changes here make it easier to customize the look of the virtual keyboard.