Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check exit codes for commands in the browse_build function #3227

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

meganschanz
Copy link
Contributor

We had noticed that it was possibly for the sort command in the browse_build function in the index-alphabetic-browse.sh script to fail, but since it was not checking the exit code of that sort command, it was improperly returning an exit code of zero. Instead of just adding the check for that command I thought it wouldn't hurt to have the exit code check on all the commands in that browse_build function.

This is particularly useful for us because we have a wrapper script around index-alphabetic-browse.sh that will alert us when there are failures (i.e. the script exits with a non-zero exit code).

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @meganschanz, this is a useful improvement. I also appreciate the addition of comments!

I don't have the time or inclination to fully port this to the Windows version of the script, but I did at least align the comments between the two versions -- see 3d47b63.

@demiankatz demiankatz merged commit f5e3500 into vufind-org:dev Nov 17, 2023
7 checks passed
@demiankatz demiankatz added this to the 10.0 milestone Nov 17, 2023
@meganschanz meganschanz deleted the browse-build-exit-codes branch November 17, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants