Check exit codes for commands in the browse_build function #3227
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had noticed that it was possibly for the
sort
command in thebrowse_build
function in theindex-alphabetic-browse.sh
script to fail, but since it was not checking the exit code of thatsort
command, it was improperly returning an exit code of zero. Instead of just adding the check for that command I thought it wouldn't hurt to have the exit code check on all the commands in thatbrowse_build
function.This is particularly useful for us because we have a wrapper script around
index-alphabetic-browse.sh
that will alert us when there are failures (i.e. the script exits with a non-zero exit code).