Add a view helper for bulk options, checkboxes and cart controls. #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
demiankatz
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Thanks for this, @EreMaijala! Here are some initial thoughts based on a readthrough of the changes. I'll do hands-on testing after we finish discussing this round of feedback.
demiankatz
added
the
architecture
demiankatz
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spun from #2929: stop carrying around the flags for bulk actions, checkboxes and cart controls. Encapsulates all the logic in a view helper.
TODO