Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KohaRest: Fix error in items sorting when serial isssue number is null #3301

Closed

Conversation

xmorave2
Copy link
Contributor

@xmorave2 xmorave2 commented Jan 9, 2024

Sometimes the number key in status array is null, the sorting number then fails, because strnatcmp function needs arguments to be strings.

@xmorave2 xmorave2 requested a review from EreMaijala January 9, 2024 13:25
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@demiankatz demiankatz changed the title Fix error in items sorting when serial isssue number is null KohaRest: Fix error in items sorting when serial isssue number is null Jan 9, 2024
@demiankatz
Copy link
Member

Thanks, @xmorave2! Since this is a simple fix, I've backported it to the release-9.1 branch.

@demiankatz demiankatz closed this Jan 9, 2024
@demiankatz demiankatz added this to the 9.1.1 milestone Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants