[VUFIND-1674] Show count of saved items in account menu #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
commented
Jul 25, 2024
| public function handleRequest(Params $params) | ||
| { | ||
| $this->disableSessionWrites(); // avoid session write timing bug | ||
| $count = $this->user ? count($this->resourceService->getFavorites($this->user)) : 0; |
There was a problem hiding this comment.
Is it worth creating a new resourceService method that just returns a count to reduce the amount of data pushed around, or is it better to keep this simple and trust the caching?
demiankatz
commented
Jul 25, 2024
| @@ -107,3 +107,7 @@ | |||
| <?=$this->recommend($current)?> | |||
| <?php endforeach; ?> | |||
| </div> | |||
|
|
|||
| <?php if (!isset($list)): ?> | |||
There was a problem hiding this comment.
Right now, the cache only gets invalidated when you go to the favorites page. Maybe it would be better to always invalidate the cache on all list pages, so that list actions cause the favorites total to get recalculated. However, this would make a lot of unnecessary requests or would require the addition of some additional logic to figure out when invalidation is really needed.
3 tasks
|
This needs more time to mature, so I am moving it to the 11.0 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial proof of concept.
TODO