Fix PHP 8.2 deprecations #3893
Merged
Fix PHP 8.2 deprecations #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmorave2
commented
Aug 28, 2024
| * | ||
| * @return string The input string converted to UTF-8 | ||
| */ | ||
| protected function toUTF8($s) |
There was a problem hiding this comment.
This method is no more used, co I removed it instead of fixing it
|
There are changes in Voayger ILS drivers, but I have no access to any Voyager system, so I can not test it... |
demiankatz
added
the
architecture
demiankatz
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks, @xmorave2! This all makes sense to me. Like you, I am no longer able to directly test the Voyager drivers. However, I was able to write unit tests to exercise enough of the changed code to convince myself that it's safe to merge. (I confirmed that the tests passed both here and in the dev branch).
LuomaJuha
pushed a commit
to LuomaJuha/NDL-VuFind2
that referenced
this pull request
Oct 1, 2024
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.php.net/releases/8.2/en.php