Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class for components #4071

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Conversation

LuomaJuha
Copy link
Contributor

@LuomaJuha LuomaJuha commented Nov 12, 2024

Adds a class for components, so adjusting styles locally is easier. Small adjustments to the code.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LuomaJuha -- see below for a few questions, comments and suggestions.

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all of my comments, @LuomaJuha -- just a couple more thoughts now...

module/VuFind/src/VuFind/View/Helper/Root/Component.php Outdated Show resolved Hide resolved
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I gave this another thought I'd like a bit of explanation why this is needed and a good thing. I'm not sure the possible benefits outweigh the potential confusion this can cause if a theme's styles target another.

@LuomaJuha LuomaJuha changed the title Add a theme specific class for components Add class for components Nov 13, 2024
@LuomaJuha
Copy link
Contributor Author

Reverted the changes for theme-specificity, as it could have caused confusion, but left the _componentClass to be used later for overwriting styles

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification, @LuomaJuha! Just one last documentation-oriented suggestion below.

module/VuFind/src/VuFind/View/Helper/Root/Component.php Outdated Show resolved Hide resolved
@demiankatz demiankatz requested review from EreMaijala and removed request for EreMaijala November 13, 2024 14:50
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LuomaJuha -- looks good to me, and all tests are still passing.

I can't merge this without dismissing @EreMaijala's open review, so I'll wait and see if he has any final thoughts before finalizing the work.

@demiankatz demiankatz added this to the 11.0 milestone Nov 13, 2024
@LuomaJuha
Copy link
Contributor Author

Sure!

@demiankatz demiankatz merged commit a7f0659 into vufind-org:dev Nov 14, 2024
6 checks passed
@LuomaJuha LuomaJuha deleted the add-wrapper-class-option branch November 14, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants