-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Searchbox #814
One Searchbox #814
Conversation
Conflicts: themes/bootprint3/css/compiled.css themes/bootstrap3/css/compiled.css
Conflicts: themes/bootprint3/css/compiled.css themes/bootstrap3/css/compiled.css themes/bootstrap3/templates/header.phtml
I believe that, in our discussion of this, it was suggested that we should continue to use a class instead of an ID for the search box even if we remove the duplicate one. (I think there were some use cases around embedding multiple VuFind boxes on a single page, though I can't remember who mentioned this or what the details were). In any case, reverting the class-->id switch would certainly make the diffs in this PR smaller. What do you think? |
Conflicts: themes/bootprint3/css/compiled.css
@crhallberg, are there any outstanding issues here? This seems to be working fine for me. If you're not aware of any remaining issues, perhaps you should run the full test suite on this branch one more time to be sure all is well and then merge if so. |
Some errors are coming up in the full test, maybe be a cascading timing issue though. Working on it now. |
Finally got my test instance working consistently again. Tests have passed. Sorry for the delay. |
Thanks, Chris, I've gone ahead and merged this. |
Simplify VuFind to only have one searchbox.
All checked installations of VuFind using the searchbox in-line with the logo and menu had completely custom layouts. Having the searchbox on the next line is the most popular. This PR removes the top searchbox and simplifies css and js logic.