Receipts #21

rmulhol · 2018-07-11T15:58:31Z

Resolves #5

Addresses #20 (logs can be fetched via receipts)

- correction to acknowledge plural iplds - also bumps default ending block number

- Allows validation logic to be tested

- Since we're focusing on Geth, there's no need to fetch and decode raw RLP data

- Removes the need for an additional decoding step when decoded header is desired

- Since `ReadHeaderRLP` does not return an error, there's nothing for us to catch

elizabethengelman

This looks good to me! I really like the change of uses the actual types (types.Body, types.Receipt, etc). 👏

rmulhol added 7 commits July 10, 2018 11:19

Update README to reflect state/storage trie fetching status

987381b

Rename block headers command

81bf866

- correction to acknowledge plural iplds - also bumps default ending block number

Create IPLDs for blocks' receipts

20ed03c

Move block range validation to transformers

6daaf7c

- Allows validation logic to be tested

Fetch decoded block body from the DB

ef8d943

- Since we're focusing on Geth, there's no need to fetch and decode raw RLP data

Fetch decoded header from LevelDB

ec08ff4

- Removes the need for an additional decoding step when decoded header is desired

Remove impossible error condition

49a7b9c

- Since `ReadHeaderRLP` does not return an error, there's nothing for us to catch

rmulhol requested review from JamesChristie and elizabethengelman July 11, 2018 15:58

elizabethengelman approved these changes Jul 12, 2018

View reviewed changes

rmulhol merged commit 6d1b27b into master Jul 12, 2018

rmulhol deleted the receipts branch July 12, 2018 21:48

rmulhol restored the receipts branch July 12, 2018 22:05

rmulhol deleted the receipts branch July 12, 2018 22:06

Provide feedback