Automatic removal of orphan nodes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using variadic arguments is very non-intrusive way to introduce options. This is very generic, and will allow to implement other options in the future.
sha256(testKey) = 0001... sha256(testKey2) = 1000... sha256(foo) = 0010...
no case produces nil sideNodes; nothing modifies the stored hashes
|
hey, want to open this PR against upstream? This way we can get feedback from the celestia team. |
|
@marbar3778 yes, I planned to after a review on our side, but I will just go ahead. Upstream PR: celestiaorg#37 |
oh sorry for jumping the gun. I was talking with the celestia team and it came up. |
Store values in a separate mapstore indexed by (hash(value)+key); allows pruning values Simplify pruning loops slightly as well
roysc
force-pushed
the
tzdybal/remove_orhpans
branch
from
341c998 to
48e4ab9
Compare
can short circuit when the same value is already set
Co-authored-by: John Adler <adlerjohn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree nodes (and value mappings) orphaned during updates and deletions are now removed when configured with
AutoRemoveOrphans.Completes work from celestiaorg#24 :
Implements vulcanize/cosmos-sdk#4.