Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

contractWatcher not marking headers checked #146

Closed
rmulhol opened this issue Sep 25, 2019 · 1 comment
Closed

contractWatcher not marking headers checked #146

rmulhol opened this issue Sep 25, 2019 · 1 comment

Comments

@rmulhol
Copy link
Contributor

rmulhol commented Sep 25, 2019

Still tracking down exactly how this happens, but it seems that the contractWatcher does not always mark all headers as checked while running in header mode. Adding a MarkHeaderCheckedForAll after all logs have been processed in Execute appears to correct the issue - otherwise the same headers are continually treated as unchecked on subsequent runs.
@i-norden
Copy link
Collaborator

i-norden commented Oct 7, 2019

Need to confirm this but I think this is happening when there are no logs for a contract for the header, but there are for other contracts such that this is hit but this wasn't.

i-norden added a commit that referenced this issue Oct 8, 2019
@i-norden
fix for issue #146; mark header checked for contract if it doesnt hav…
68e3dd1 
…e any logs at that header but other contracts do
i-norden added a commit that referenced this issue Oct 11, 2019
@i-norden
fix for issue #146; mark header checked for contract if it doesnt hav…
7ed1432 
…e any logs at that header but other contracts do
i-norden added a commit that referenced this issue Oct 15, 2019
@i-norden
fix for issue #146; mark header checked for contract if it doesnt have
d37a4d0 
any logs at that header but other contracts do; test
i-norden added a commit that referenced this issue Oct 24, 2019
@i-norden
fix for issue #146; mark header checked for contract if it doesnt have
11e303b 
any logs at that header but other contracts do; test
i-norden added a commit that referenced this issue Oct 28, 2019
@i-norden
fix for issue #146; mark header checked for contract if it doesnt have
11b5efb 
any logs at that header but other contracts do; test
i-norden added a commit that referenced this issue Oct 28, 2019
@i-norden
Merge pull request #158 from vulcanize/missed_marked_checked_headers
b767531 
Fix for issue #146
@i-norden i-norden closed this as completed Dec 3, 2019
grizz pushed a commit that referenced this issue Dec 22, 2019
@i-norden @grizz
fix for issue #146; mark header checked for contract if it doesnt have
4af5cb9 
any logs at that header but other contracts do; test
grizz pushed a commit to dipd/vulcanizedb that referenced this issue Dec 28, 2019
@i-norden @grizz
fix for issue vulcanize#146; mark header checked for contract if it d…
27c6183 
…oesnt have

any logs at that header but other contracts do; test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmulhol @i-norden