This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Adds ability to set log level from toml or CLI args #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaoandrew
requested review from
i-norden,
rmulhol,
elizabethengelman and
Gslaughl
i-norden
approved these changes
Jun 26, 2019
yaoandrew
force-pushed
the
vdb-605-add-debug-logging
branch
from
2fbf623 to
11a65c5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the ability to change the log levels via CLI flag or toml file
--changes level on header validation window to debug
Could use some suggestions on where to log to address this part:
"More detail on making sure the storage watcher is running"