This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Storage diffs over rpc #116
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -48,6 +48,7 @@ var ( | |
| recheckHeadersArg bool | ||
| SubCommand string | ||
| LogWithCommand log.Entry | ||
| stateDiffSource string | ||
| ) | ||
|
|
||
| const ( | ||
|
|
@@ -120,6 +121,7 @@ func init() { | |
| rootCmd.PersistentFlags().String("filesystem-storageDiffsPath", "", "location of storage diffs csv file") | ||
| rootCmd.PersistentFlags().String("exporter-name", "exporter", "name of exporter plugin") | ||
| rootCmd.PersistentFlags().String("log-level", log.InfoLevel.String(), "Log level (trace, debug, info, warn, error, fatal, panic") | ||
| rootCmd.PersistentFlags().StringVar(&stateDiffSource, "state-diff-source", "csv", "where to get the state diffs: csv or geth") | ||
|
|
||
| viper.BindPFlag("database.name", rootCmd.PersistentFlags().Lookup("database-name")) | ||
| viper.BindPFlag("database.port", rootCmd.PersistentFlags().Lookup("database-port")) | ||
|
|
@@ -152,15 +154,21 @@ func initConfig() { | |
| } | ||
|
|
||
| func getBlockChain() *geth.BlockChain { | ||
|
There was a problem hiding this comment. Is it time to rename the There was a problem hiding this comment. Created a new story for this, so there's more time for conversation and thought put into this decision: VDB-778. There was a problem hiding this comment. Could you remind me where these stories are located? There was a problem hiding this comment. @i-norden sorry, i totally missed this question earlier! they're on the Jira board. I'd be happy to also add them to the issues on this repo too, if that's easier. |
||
| rpcClient, ethClient := getClients() | ||
| vdbEthClient := client.NewEthClient(ethClient) | ||
| vdbNode := node.MakeNode(rpcClient) | ||
| transactionConverter := vRpc.NewRpcTransactionConverter(ethClient) | ||
| return geth.NewBlockChain(vdbEthClient, rpcClient, vdbNode, transactionConverter) | ||
|
There was a problem hiding this comment. Is it time to rename There was a problem hiding this comment. Created a new story for this, so there's more time for conversation and thought put into this decision: VDB-779. |
||
| } | ||
|
|
||
| func getClients() (client.RpcClient, *ethclient.Client) { | ||
| rawRpcClient, err := rpc.Dial(ipc) | ||
|
|
||
| if err != nil { | ||
| LogWithCommand.Fatal(err) | ||
| } | ||
| rpcClient := client.NewRpcClient(rawRpcClient, ipc) | ||
| ethClient := ethclient.NewClient(rawRpcClient) | ||
|
|
||
| return rpcClient, ethClient | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse code across execute and composeAndExecute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 pulled this into a story: VDB-777. I'd be happy to move it to an issue on this repo instead, if that makes more sense.