Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Logging enhancement #120

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Logging enhancement #120

merged 4 commits into from
Jul 23, 2019

Conversation

yaoandrew
Copy link
Contributor

  • Adds the calling method to trace and debug log levels
  • Adds the subCommand (ie headerSync, composeAndExecute) to log message fields
  • Incorporates Edvards format changes and additional logging

m0ar
m0ar reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@m0ar m0ar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think it makes sense to populate a global variable with our currently running command, it would simplify this a lot and remove the need for passing around arguments that are only relevant for logging and not the actual execution. :)

cmd/compose.go Outdated Show resolved Hide resolved
cmd/compose.go Outdated Show resolved Hide resolved
cmd/contractWatcher.go Outdated Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
environments/infura.toml Outdated Show resolved Hide resolved
pkg/history/block_validator_test.go Outdated Show resolved Hide resolved
@yaoandrew yaoandrew marked this pull request as ready for review July 19, 2019 04:15
rmulhol
rmulhol approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@rmulhol rmulhol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few non-blocking comments

cmd/compose.go Show resolved Hide resolved
cmd/contractWatcher.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
pkg/history/block_validator.go Outdated Show resolved Hide resolved
elizabethengelman
elizabethengelman approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

Just a couple of non-blocking questions.

cmd/coldImport.go Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
@yaoandrew yaoandrew merged commit a3b55bf into staging Jul 23, 2019
@yaoandrew yaoandrew deleted the logging-enhancement branch July 23, 2019 20:23
@elizabethengelman elizabethengelman mentioned this pull request Jul 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m0ar m0ar m0ar left review comments

@rmulhol rmulhol rmulhol approved these changes

@elizabethengelman elizabethengelman elizabethengelman approved these changes

@aaizuss aaizuss Awaiting requested review from aaizuss

@Gslaughl Gslaughl Awaiting requested review from Gslaughl

@i-norden i-norden Awaiting requested review from i-norden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaoandrew @m0ar @elizabethengelman @rmulhol