Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Removes _checked from column name query #124

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

yaoandrew
Copy link
Contributor

This change is needed to support Edvard's config refactor. It will remove the "_checked" part of the query and return a collection of column names (transformers) to be used with the new configs here: vulcanize/mcd_transformers#154

@rmulhol
Copy link
Contributor

rmulhol commented Jul 30, 2019

@i-norden curious if any pitfalls jump out at you with these changes - namely, if they affect other things you're working on

@@ -76,7 +76,8 @@ func GetCheckedColumnNames(db *postgres.DB) ([]string, error) {
`SELECT column_name FROM information_schema.columns
WHERE table_schema = 'public'
AND table_name = 'checked_headers'
AND column_name ~ '_checked';`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should update the expected column names in the test to omit _checked?

@i-norden
Copy link
Collaborator

i-norden commented Jul 30, 2019

@rmulhol the seed node stuff isn't concerned with the checked_headers columns, and the contract_watcher code and any of its derivative ContractTransformers (e.g. ENS domain_records and non-seed-node-based account transformers) don't use this repository interface so those will be unaffected. I do think this will necessitate changes to any other EventTransformers though, i.e. all the individual ENS event transformers here but that doesn't seem like an issue, they can continue to work with older versions of vulcanizedb and can be updated if need be. Thank you for checking!!

@yaoandrew yaoandrew merged commit 65e762f into staging Jul 31, 2019
@yaoandrew yaoandrew deleted the refactor-mcd-configs branch July 31, 2019 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants