-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Just curious what the impetus for updating some of these deps is, besides make sure we're have the most recent versions.
I wonder if a similar update needs to made to transformer repos too. 🤔Locally I think I've seen plugin was built with a different version of package...
errors if vdb deps don't match up with transformer deps (specifically the geth version).
github.com/graph-gophers/graphql-go v0.0.0-20190610161739-8f92f34fc598 // indirect | ||
github.com/hashicorp/golang-lru v0.0.0-20180201235237-0fb14efe8c47 | ||
github.com/howeyc/fsnotify v0.9.0 // indirect | ||
github.com/ethereum/go-ethereum v1.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Yeah the main impetus is to bring it in line with current transformer repos. Basically trying to sidestep exactly that error while working on a more streamlined deploy |
@rmulhol gotcha! thanks for explanation - I'm running into this sort of issue with I wonder if there's an easier way to keep the deps in these two repos in line 🤔 |
@elizabethengelman I hope so! Thinking it should be possible to say that a versioned release on this repo should be the source of truth for versions of shared dependencies, but not yet sure how to enforce that 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.