Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Update dependencies #130

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Update dependencies #130

merged 1 commit into from
Aug 21, 2019

Conversation

rmulhol
Copy link
Contributor

@rmulhol rmulhol commented Aug 20, 2019

No description provided.

Copy link
Contributor

@elizabethengelman elizabethengelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Just curious what the impetus for updating some of these deps is, besides make sure we're have the most recent versions.

I wonder if a similar update needs to made to transformer repos too. 🤔Locally I think I've seen plugin was built with a different version of package... errors if vdb deps don't match up with transformer deps (specifically the geth version).

github.com/graph-gophers/graphql-go v0.0.0-20190610161739-8f92f34fc598 // indirect
github.com/hashicorp/golang-lru v0.0.0-20180201235237-0fb14efe8c47
github.com/howeyc/fsnotify v0.9.0 // indirect
github.com/ethereum/go-ethereum v1.9.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rmulhol
Copy link
Contributor Author

rmulhol commented Aug 21, 2019

This LGTM. Just curious what the impetus for updating some of these deps is, besides make sure we're have the most recent versions.

I wonder if a similar update needs to made to transformer repos too. 🤔Locally I think I've seen plugin was built with a different version of package... errors if vdb deps don't match up with transformer deps (specifically the geth version).

Yeah the main impetus is to bring it in line with current transformer repos. Basically trying to sidestep exactly that error while working on a more streamlined deploy

@elizabethengelman
Copy link
Contributor

@rmulhol gotcha! thanks for explanation - I'm running into this sort of issue with storage-diffs-over-rpc right now as well.

I wonder if there's an easier way to keep the deps in these two repos in line 🤔

@rmulhol
Copy link
Contributor Author

rmulhol commented Aug 21, 2019

@elizabethengelman I hope so! Thinking it should be possible to say that a versioned release on this repo should be the source of truth for versions of shared dependencies, but not yet sure how to enforce that 🤔

Copy link
Contributor

@Gslaughl Gslaughl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rmulhol rmulhol merged commit e093ad3 into staging Aug 21, 2019
@rmulhol rmulhol deleted the update-deps branch August 21, 2019 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants