This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Do nothing on duplicate log insert in contract watcher #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
rmulhol
changed the title
- Prevents duplicate key constraint violation from blocking the process from moving forward on restart. - If header_id, log_idx, and tx_idx are the same, we can safely do nothing since it's definitely the same log - a reorg would cause the original header to be replaced with a new ID.
rmulhol
force-pushed
the
contract-watcher-duplicate-inserts
branch
from
98f345d
to
37e2673
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from moving forward on restart.
nothing since it's definitely the same log - a reorg would cause the
original header to be replaced with a new ID.
Resolves #140