This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Pin to urfave/cli version in go.mod #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
go.mod
Outdated
| ) | ||
|
|
||
| replace github.com/ethereum/go-ethereum => github.com/vulcanize/go-ethereum v0.0.0-20190731183759-8e20673bd101 | ||
|
|
||
| replace gopkg.in/urfave/cli.v1 => gopkg.in/urfave/cli.v1 v1.20.0 |
There was a problem hiding this comment.
When trying this out locally pointing to the mcd statediffing branch, I'm getting an "unable to build .so file: exit status 1 error when building without this line. But composes and executes okay if we pin the version to v1.20.0 AND keep this line in for some reason. 🤷♀
There was a problem hiding this comment.
Sounds in line with my go mod experiences so far!
- Attempting to fix error: github.com/vulcanize/vulcanizedb@v0.0.8 requires gopkg.in/urfave/cli.v1@v1.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
elizabethengelman
force-pushed
the
pin-urfave-cli
branch
from
6cbb34f
to
7e0728b
Compare
grizz
pushed a commit
that referenced
this pull request
Dec 22, 2019
* Pin to urfave/cli version in go.mod - Attempting to fix error: github.com/vulcanize/vulcanizedb@v0.0.8 requires gopkg.in/urfave/cli.v1@v1.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
grizz
pushed a commit
to dipd/vulcanizedb
that referenced
this pull request
Dec 28, 2019
* Pin to urfave/cli version in go.mod - Attempting to fix error: github.com/vulcanize/vulcanizedb@v0.0.8 requires gopkg.in/urfave/cli.v1@v1.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires gopkg.in/urfave/cli.v1@v1.0.0-00010101000000-000000000000:
invalid version: unknown revision 000000000000