This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Remove LogNote Transformer and Converter #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabethengelman
requested review from
Gslaughl,
i-norden,
m0ar,
rmulhol and
yaoandrew
Gslaughl
pushed a commit
that referenced
this pull request
May 1, 2019
* Factorise dent transformer * Update dent transformer tests * Add additional tests to dent repository test * Update dent to use LogNoteTransformer factory
i-norden
approved these changes
May 1, 2019
There was a problem hiding this comment.
This looks good to me! Thank you for removing this, the fewer things for a developer to sort through in the shared directory the better. I wonder if we should create a public repo for the log note transformers, depending on how long the mcd_transformers repo will remain private?
|
@i-norden thanks for the review! Part of the reason I removed this from core vulcanize was because it seemed pretty specific to to the way the client's contract events were constructed. So I'm not entirely sure how it would be useful to put into a public repo - is there another more general use case that you're thinking of that may need this transformer? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this from vulcanize core in favor of including it a client specific transformer plugin, since it is specific to their event implementations.