This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Remove handling of duplicate storage diffs in watcher #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
m0ar
approved these changes
May 16, 2019
| @@ -139,7 +139,7 @@ func execute() { | |||
| func init() { | |||
| rootCmd.AddCommand(executeCmd) | |||
| executeCmd.Flags().BoolVarP(&recheckHeadersArg, "recheck-headers", "r", false, "whether to re-check headers for watched events") | |||
| executeCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5*time.Minute, "how often to recheck queued storage diffs") | |||
| executeCmd.Flags().DurationVarP(&queueRecheckInterval, "queue-recheck-interval", "q", 5*time.Minute, "interval duration for rechecking queued storage diffs (ex: 5m30s)") | |||
i-norden
approved these changes
May 20, 2019
| @@ -100,6 +100,7 @@ type Repository interface { | |||
| A contract-specific implementation of the repository interface enables the transformer to write the decoded storage value to the appropriate table in postgres. | |||
|
|
|||
| The `Create` function is expected to recognize and persist a given storage value by the variable's name, as indicated on the row's metadata. | |||
| Note: we advise silently discarding duplicates in `Create` - as it's possible that you may read your the same diff several times, and an error will trigger the storage watcher to queue that diff for later processing. | |||
There was a problem hiding this comment.
"may read your the same diff"
- Can push this responsibility down to the transformers - Update docs to reflect that transformers should handle duplicates
rmulhol
force-pushed
the
remove-storage-diff-duplicate-handling
branch
from
4f688b5 to
e290979
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was thinking that it might be helpful to have docs for what the storage watcher is doing, but going to postpone that until our current doc improvement iteration is wrapped up.
Not simply reverting the previous commit since it includes some formatting improvements, and this includes some documentation improvements.