Triangle example panics when using ImageLayout::Undefined

[jedel1043]

Issue

Running the triangle example using the same render pass configuration from https://github.com/KhronosGroup/Vulkan-Samples/blob/master/samples/api/hello_triangle/hello_triangle.cpp panics with the message:

thread 'main' panicked at 'assertion failed: !matches!(new_layout, ImageLayout :: Undefined | ImageLayout ::\n        Preinitialized)'

Stacktrace points to:

vulkano/vulkano/src/command_buffer/commands/sync.rs

Lines 326 to 329 in 5c6bbe0

	debug_assert!(!matches!(
	new_layout,
	ImageLayout::Undefined | ImageLayout::Preinitialized
	));

I've also tested version 0.29.0 and it works fine, so the regression was implemented after that release.

Render pass creation snippet

let render_pass = {
        use vulkano::image::{ImageLayout, SampleCount};
        use vulkano::render_pass::{
            AttachmentDescription, AttachmentReference, LoadOp, RenderPassCreateInfo, StoreOp,
            SubpassDependency, SubpassDescription,
        };
        use vulkano::sync::{AccessFlags, PipelineStages};
        let colour_attachment = AttachmentDescription {
            format: Some(swapchain.image_format()),
            samples: SampleCount::Sample1,
            load_op: LoadOp::Clear,
            store_op: StoreOp::Store,
            stencil_load_op: LoadOp::DontCare,
            stencil_store_op: StoreOp::DontCare,
            initial_layout: ImageLayout::Undefined,
            final_layout: ImageLayout::PresentSrc,
            ..Default::default()
        };

        let colour_attachment_ref = AttachmentReference {
            attachment: 0,
            layout: ImageLayout::ColorAttachmentOptimal,
            ..Default::default()
        };

        let subpass = SubpassDescription {
            color_attachments: vec![Some(colour_attachment_ref)],
            ..Default::default()
        };

        let dep = SubpassDependency {
            source_subpass: None,
            destination_subpass: Some(0),
            source_stages: PipelineStages {
                color_attachment_output: true,
                ..PipelineStages::none()
            },
            destination_stages: PipelineStages {
                color_attachment_output: true,
                ..PipelineStages::none()
            },
            source_access: AccessFlags::none(),
            destination_access: AccessFlags {
                color_attachment_read: true,
                color_attachment_write: true,
                ..AccessFlags::none()
            },
            ..Default::default()
        };

        RenderPass::new(
            device.clone(),
            RenderPassCreateInfo {
                attachments: vec![colour_attachment],
                subpasses: vec![subpass],
                dependencies: vec![dep],
                ..Default::default()
            },
        )
        .unwrap()
    };

System Info

• Version of vulkano: 5c6bbe0
• OS: Windows 10
• GPU (the selected PhysicalDevice): NVIDIA GeForce GTX 1050
• GPU Driver: Nvidia driver 511.65
• Vulkan Runtime: 1.0.33.0
• Vulkan SDK: 1.3.211.0
• Upload of a reasonably minimal complete main.rs file that demonstrates the issue: https://github.com/vulkano-rs/vulkano/blob/master/examples/src/bin/triangle.rs but replace the let render_pass = ... statement with the above snippet (and fix some API breaking changes)