Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ready() -> bool function in FenceSignalFuture #1907

Closed
AndrewB330 opened this issue Jun 4, 2022 · 0 comments · Fixed by #1910
Closed

No ready() -> bool function in FenceSignalFuture #1907

AndrewB330 opened this issue Jun 4, 2022 · 0 comments · Fixed by #1910

Comments

@AndrewB330
Copy link

  • Version of vulkano: "0.29.0"

In the codebase I see that Fence has two associated functions: ready(&self) -> Result<bool, OomError> and wait(&self, timeout: Option<Duration>) -> Result<(), FenceWaitError>. When I'm constructing a future like in the examples I'm getting an instance of FenceSignalFuture (after calling then_signal_fence_and_flush).

But I want to keep updating my scene on CPU, while checking each time if previous frame finished rendering and freed access to storage buffers so that I can upload new data to them. For that I wanted to have some function like ready to check if future is ready without blocking the cpu.

Can that be added? If no, then how can I get the behavior I described?
I can try to make a PR for that, but I'm not sure right now if I'm using the API in a correct way, so asking for a suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant