Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_signaled to FenceSignalFuture #1910

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Add is_signaled to FenceSignalFuture #1910

merged 1 commit into from
Jun 5, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Jun 5, 2022

Changelog:

- **Breaking** Renamed the `ready` method of `Fence` to `is_signaled`.
- Added an `is_signaled` method to `FenceSignalFuture`.

Fixes #1907. I renamed the function to better fit Rust method naming guidelines and Vulkan terminology.

AustinJ235
AustinJ235 approved these changes Jun 5, 2022
View reviewed changes
Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough and useful.

@AustinJ235 AustinJ235 merged commit aaf0ead into vulkano-rs:master Jun 5, 2022
AustinJ235 added a commit that referenced this pull request Jun 5, 2022
@AustinJ235
#1910 Changelog Update
bd53e74
@Rua Rua deleted the fence-is_signaled branch September 17, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AustinJ235 AustinJ235 AustinJ235 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No ready() -> bool function in FenceSignalFuture
2 participants
@Rua @AustinJ235