Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issues, and highlight important implementation aspects.
Vulkano currently doesn't support the following:
Single-layer array. Sounds stupid, but perfectly valid (?). In my particular use case, I used asampler2DArray[]
to store textures of different sizes/formats, with auto-generated descriptors and name-to-index lookup - which didn't quite work out at first because one of the arrays only have a single image. Yes, there will probably never exist a finished product containing single-layer array textures, but auto-inferred type that cannot be overridden is probably still a bad design.This pull request aims to fix the issues.
Notes:
I have zero idea what am I doing... It seems to work and the existing tests seem to have passed, but that could be an illusion.
I have not tested support for 1D/3D images yet. Maybe I will commit a example containing them in this PR later.
Perhaps breaking the API is not a good idea?P.S.: I am not a native English speaker, the ambiguous terminology is making my head spin and I am submitting this PR in the middle of the night... this PR is about
sampler2DArray
in GLSL or whatever the thing presented in this example is. Any ambiguous terms above are referring tosampler2DArray
.Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
files(
CHANGELOG_VULKANO.md
andCHANGELOG_VK_SYS.md
)by maintainers right after the Pull Request merge.
Entries for Vulkano changelog:
**Breaking** Breaking entry description.
Non-breaking entry description.
...Entries for VkSys changelog:
Entry 1.
Entry 2.
...cargo fmt
on the changes.Maybe after the reviews... (rust-lang/rustfmt#1324)
... um, immutable.rs and view.rs does not seems to contain any tests in the first place?