Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix queue 'supports_' methods with empty flags #1822

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

xor-bits
Copy link
Contributor

@xor-bits xor-bits commented Feb 9, 2022

The methods prefixed with supports_ in vulkano::device::physical::QueueFamily should use the contains method with queue_flags. This makes sure that if the tested flags are are empty, they are supported. This fixes a panic when for example: timestamping PipelineStage::TopOfPipe, PipelineStage::BottomOfPipe or PipelineStage::AllCommands where no flags are required for them to be supported.

@Rua
Copy link
Contributor

Rua commented Feb 9, 2022

Thanks again for the fix!

@Rua Rua merged commit d701a3a into vulkano-rs:master Feb 9, 2022
Rua added a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants