Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnsafeDescriptorSetCreateInfo #1843

Merged
merged 3 commits into from
Feb 26, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Feb 26, 2022

Changelog:

- **Breaking** `UnsafeDescriptorPool` creation parameters are given using `UnsafeDescriptorPoolCreateInfo`.
- **Breaking** The `alloc` and `free` methods of `UnsafeDescriptorPool` are renamed to `allocate_descriptor_sets` and `free_descriptor_sets`.
- **Breaking** The `alloc` method of the `DescriptorPool` trait is renamed to `allocate`.
- **Breaking** `DescriptorSetLayout::descriptors_count` is renamed to `descriptor_counts`, and returns a hashmap instead of a separate type.

Not too complicated here either. I removed the DescriptorsCount type, because the same effect could be achieved more flexibly with a hashmap.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but I think we should remove the use of the fnv crate. FnvHashMap was used in a time where the std implementation was slower than desired. Now days rust is using hashbrown since version 1.36 and is more performant. On top of the fnv hasn't been updated in 2 years.

vulkano/src/descriptor_set/layout.rs Show resolved Hide resolved
@AustinJ235 AustinJ235 merged commit 550b4c3 into vulkano-rs:master Feb 26, 2022
AustinJ235 added a commit that referenced this pull request Feb 26, 2022
@Rua Rua deleted the UnsafeDescriptorPoolCreateInfo branch May 31, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants