Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnsafeImageCreateInfo and ImageViewCreateInfo #1844

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

Rua
Copy link
Contributor

@Rua Rua commented Feb 26, 2022

Changelog:

- **Breaking** `UnsafeImage` creation parameters are given using `UnsafeImageCreateInfo`.
- **Breaking** `ImageView` creation parameters are given using `ImageViewCreateInfo`.
- **Breaking** `ImageView::new` has been renamed to `new_default`.
- **Breaking** `ImageView::ty` has been renamed to `view_type`.
- **Breaking** The `format` methods of `UnsafeImage` and `ImageViewAbstract` now return `Option<Format>`.
- **Breaking** `UnsafeImage::flags` has been replaced with methods to return individual flags.

Copy link
Member

@AustinJ235 AustinJ235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out, great work!

@AustinJ235 AustinJ235 merged commit 9e8682f into vulkano-rs:master Feb 27, 2022
AustinJ235 added a commit that referenced this pull request Feb 27, 2022
@Rua Rua deleted the image-view branch May 31, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants